Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy types #292

Merged
merged 23 commits into from
Sep 23, 2022
Merged

Add proxy types #292

merged 23 commits into from
Sep 23, 2022

Conversation

cdamian
Copy link
Contributor

@cdamian cdamian commented Sep 6, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #292 (dc838a2) into master (c4bbd50) will decrease coverage by 0.61%.
The diff coverage is 72.99%.

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   69.41%   68.79%   -0.62%     
==========================================
  Files         130      132       +2     
  Lines        6732     6794      +62     
==========================================
+ Hits         4673     4674       +1     
- Misses       1359     1410      +51     
- Partials      700      710      +10     
Impacted Files Coverage Δ
rpc/author/pending_extrinsics.go 45.45% <0.00%> (-18.19%) ⬇️
types/beefy.go 78.82% <0.00%> (ø)
types/codec/codec.go 16.32% <ø> (ø)
types/event_record.go 64.00% <ø> (ø)
types/events.go 86.02% <ø> (-1.05%) ⬇️
types/option.go 100.00% <ø> (ø)
types/extrinsic_payload.go 41.53% <50.00%> (ø)
types/proxy.go 50.00% <50.00%> (ø)
types/extrinsic.go 58.00% <58.33%> (-0.79%) ⬇️
types/account_id.go 78.26% <64.28%> (-21.74%) ⬇️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment around the error format.

types/generic.go Show resolved Hide resolved
gethrpc/client.go Show resolved Hide resolved
types/header.go Outdated Show resolved Hide resolved
types/metadataV14.go Show resolved Hide resolved
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cdamian cdamian merged commit e6e34e3 into master Sep 23, 2022
@cdamian cdamian deleted the add-proxy-types branch September 23, 2022 10:59
yrong pushed a commit to Snowfork/go-substrate-rpc-client that referenced this pull request May 22, 2024
* types: Add entities from the keystore pallet

* keystore: Change enum to uint alias

* account_id: Add helper methods

* account_id: Add equal method

* proxy: Add proxy storage types

* proxy: Add name and value maps for proxy type

* types: Check bytes length when creating account ID

* types: Add more tests

* proxy: Add anchor management proxy type

* proxy: Implement encode/decode for ProxyStorageEntry and ProxyDefinition

* keystore: Add keystore events

* types: Rename uniques pallet vars

* tests: Fix proxy tests

* types: Add generic option

* proxy: Update proxy types

* types: Use [4]U8 for module error

* metadata: Use [4]U8 for metadata.FindError

* types: Use U128 for item IDs for uniques pallet events

* types: Export testing functions

* types: Fix lint errors

* option: Add HasValue method

* client: Add extra check for closed connections

* header: Remove OptionBlockNumber
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants