Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

claim root hashes value instead of map #830

Merged
merged 3 commits into from
Jun 15, 2022
Merged

claim root hashes value instead of map #830

merged 3 commits into from
Jun 15, 2022

Conversation

mikiquantum
Copy link
Contributor

@mikiquantum mikiquantum commented Jun 10, 2022 •
edited
Loading

Potential change (pending agreement) to change root hashes storage from a map to single value.

In addition adding try-runtime to verify upgrades against a live chain data. To execute:

cargo build --release --features=try-runtime

RUST_LOG=runtime=trace,try-runtime::cli=trace,executor=trace ./target/release/centrifuge-chain try-runtime --execution Native --chain centrifuge-local --no-spec-name-check on-runtime-upgrade live --uri wss://fullnode.parachain.centrifuge.io:443

NunoAlexandre
NunoAlexandre previously approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 100 times 💪🏻

@mikiquantum
Copy link
Contributor Author

Please @branan @NunoAlexandre have another look with the migration added and the try-runtime support moving forward (for now only on the Centrifuge Runtime and Claims)

branan
branan approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@branan branan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It ended up being a bit more boilerplate than a one-liner, but I'm glad all the infrastructure is in place now 👍

@mikiquantum mikiquantum merged commit 9093005 into parachain Jun 15, 2022
@mikiquantum mikiquantum deleted the claims/single_rh_store branch June 15, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branan branan branan approved these changes

@NunoAlexandre NunoAlexandre Awaiting requested review from NunoAlexandre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikiquantum @branan @NunoAlexandre