Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust codecov settings #1830

Merged
merged 5 commits into from
May 14, 2024
Merged

Adjust codecov settings #1830

merged 5 commits into from
May 14, 2024

Conversation

gpmayorga
Copy link
Contributor

@gpmayorga gpmayorga commented May 8, 2024

Description

  • Disable PR annotations
  • Disable frailing if codecov report fails to upload

Fixes https://kflabs.slack.com/archives/C04GNE3JP6Z/p1712311488621489

@gpmayorga gpmayorga requested a review from wischli as a code owner May 8, 2024 11:20
@gpmayorga gpmayorga enabled auto-merge (squash) May 8, 2024 11:21
lemunozm
lemunozm previously approved these changes May 8, 2024
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.54%. Comparing base (5adac81) to head (31b252a).
Report is 1 commits behind head on main.

❗ Current head 31b252a differs from pull request most recent head 981e6a5. Consider uploading reports for the commit 981e6a5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1830      +/-   ##
==========================================
+ Coverage   46.91%   48.54%   +1.63%     
==========================================
  Files         165      169       +4     
  Lines       12950    13370     +420     
==========================================
+ Hits         6075     6490     +415     
- Misses       6875     6880       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lemunozm
Copy link
Contributor

lemunozm commented May 8, 2024

I still see the error in the PR 🤔. Does the fix only apply when it's merged?

@gpmayorga
Copy link
Contributor Author

Making some more adjustments, it should be gone when the checks pass

@lemunozm
Copy link
Contributor

lemunozm commented May 8, 2024

Working as expected 🎉 But I think to be 100% sure we need to create a PR with lines of code changed and not tested 😆

Thanks! I think we can merge this now 👍🏻

@gpmayorga gpmayorga merged commit 8b20c3f into main May 14, 2024
10 checks passed
gpmayorga added a commit that referenced this pull request May 17, 2024
* remove pr annotations

* disable failing CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants