Skip to content

Commit

Permalink
Drop getrandom 💡
Browse files Browse the repository at this point in the history
I just realized that we probably only needed this because we were
importing dependencies from pallet-claims with the default-features
enabled, which caused getrandom from being pulled with enabled std WHILE
trying to build it for wasm, which caused the failing compilation
error. Now that those dependencies are imported correctly with
default-features = false, we in fact don't need this getrandom
workaround anymore :)
  • Loading branch information
NunoAlexandre authored and gruberb committed Oct 21, 2022
1 parent 86f7a62 commit f59d6e9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ members = [
clap = { version = "3.1", features = [ "derive" ] }
codec = { package = "parity-scale-codec", version = "3.0", default-features = false }
futures = { version = "0.3.21", features = ["compat"] }
getrandom = { version = "0.2", default-features = false, features = ["js"] }
hex-literal = "0.2.1"
jsonrpsee = { version = "0.15.1", features = ["server", "macros"] }
log = "0.4.8"
Expand Down Expand Up @@ -187,7 +186,6 @@ std = [
"sc-service/rocksdb",
"substrate-build-script-utils",
"sp-consensus-babe/std",
"getrandom/std",
]
runtime-benchmarks = [
"frame-benchmarking/runtime-benchmarks",
Expand Down

0 comments on commit f59d6e9

Please sign in to comment.