Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce calls to subquery #2454

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Reduce calls to subquery #2454

merged 2 commits into from
Sep 18, 2024

Conversation

onnovisser
Copy link
Collaborator

Description

Getting the latest tranche snapshots for all tranches for all pools was the cause of the large amount of calls to subquery. There was a call for each tranche, and it was done more than once for some reason. With over a hundred pools/tranches on demo that was a lot. Now getting the yields in getPools is done with one call for all pools/tranches.

#2432

Approvals

  • Dev

Screenshots

Impact

Copy link

github-actions bot commented Sep 17, 2024

PR deployed in Google Cloud
URL: https://pr2454-app-ff-production.k-f.dev
Commit #: 0bf3bcf
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented Sep 17, 2024

PR deployed in Google Cloud
URL: https://app-pr2454.k-f.dev
Commit #: 0bf3bcf
To access the functions directly check the corresponding deploy Action

Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@onnovisser onnovisser merged commit 4806f75 into main Sep 18, 2024
13 checks passed
@onnovisser onnovisser deleted the fix-subquery-fetches branch September 18, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants