Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploying LP tranches with EVM wallet #2400

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

onnovisser
Copy link
Collaborator

Description

If you are connected with an EVM wallet as the pool admin, and you click Switch to Ethereum Sepolia, the page goes blank, because the account no longer registers as a pool admin. Remember whether the user was admin at some point while on the Investors tab to keep the tab visible

#2377

Approvals

  • Dev

Screenshots

Impact

Copy link

github-actions bot commented Aug 22, 2024

PR deployed in Google Cloud
URL: https://app-pr2400.k-f.dev
Commit #: b830bf8
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented Aug 22, 2024

PR deployed in Google Cloud
URL: https://pr2400-app-ff-production.k-f.dev
Commit #: b830bf8
To access the functions directly check the corresponding deploy Action

Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@onnovisser onnovisser enabled auto-merge (squash) August 26, 2024 08:12
@onnovisser onnovisser merged commit 54b5ec0 into main Aug 26, 2024
9 checks passed
@onnovisser onnovisser deleted the deploy-domain-switch-networks branch August 26, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants