Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links style #2309

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Fix links style #2309

merged 1 commit into from
Jul 25, 2024

Conversation

kattylucy
Copy link
Collaborator

@kattylucy kattylucy commented Jul 24, 2024 •
edited
Loading

When upgrading react-router, the new <Link /> have default style of 16px over the 14px we were using before in our menu. Causing a discrepancy between the components with <Link /> and the components with <Text />

#2007

  • Dev
Screenshot 2024-07-24 at 1 26 10 PM Screenshot 2024-07-24 at 8 00 16 AM

@github-actions GitHub Actions
Copy link

PR deployed in Google Cloud
URL: https://app-pr2309.k-f.dev
Commit #: b8dcf9e
To access the functions directly check the corresponding deploy Action

@github-actions GitHub Actions
Copy link

PR deployed in Google Cloud
URL: https://pr2309-app-ff-production.k-f.dev
Commit #: b8dcf9e
To access the functions directly check the corresponding deploy Action

@kattylucy kattylucy merged commit 12cdd60 into main Jul 25, 2024
22 checks passed
@kattylucy kattylucy deleted the fix_links_styling branch July 25, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onnovisser onnovisser onnovisser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kattylucy @onnovisser