Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple pool managers without a multisig #2307

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Conversation

onnovisser
Copy link
Collaborator

@onnovisser onnovisser commented Jul 23, 2024

Description

Basically having a multisig with a threshold of 1. In reality it's not a multisig, but just having multiple addresses as the Any proxy on the pool admin proxy.

#2234

Approvals

  • Dev

Screenshots

Impact

Copy link

github-actions bot commented Jul 23, 2024

PR deployed in Google Cloud
URL: https://app-pr2307.k-f.dev
Commit #: 54d6986
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented Jul 23, 2024

PR deployed in Google Cloud
URL: https://pr2307-app-ff-production.k-f.dev
Commit #: 54d6986
To access the functions directly check the corresponding deploy Action

Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it but code looks good! 🔥

@onnovisser onnovisser enabled auto-merge (squash) July 30, 2024 12:55
@onnovisser onnovisser merged commit 622db36 into main Jul 30, 2024
11 checks passed
@onnovisser onnovisser deleted the 1-of-n-multisig branch July 30, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants