Asset list report update #2289

kattylucy · 2024-07-18T12:56:05Z

Update asset list report

Use subquery instead of onchain for the snapshots
Add new columns/value pairs
Add new date filter for asset report
Set as default filter value

Dev

github-actions · 2024-07-25T18:28:22Z

PR deployed in Google Cloud
URL: https://pr2289-app-ff-production.k-f.dev
Commit #: 4b4e7b5
To access the functions directly check the corresponding deploy Action

github-actions · 2024-07-25T18:28:28Z

PR deployed in Google Cloud
URL: https://app-pr2289.k-f.dev
Commit #: 4b4e7b5
To access the functions directly check the corresponding deploy Action

hieronx · 2024-07-28T15:53:49Z

@kattylucy I was curious to test the new asset list report for the LTF pool (https://pr2289-app-ff-production.k-f.dev/#/pools/4139607887/reporting/asset-list) but ran into a few small issues, fixed those here: #2323

Besides that, it looks great though! Nice job refactoring the centrifuge.js code to use the subquery data :)

One main comment: it would be great if the Day dropdown could default to the date of today. (but remain Jan 1 of the year for all other reports).

kattylucy · 2024-07-28T15:55:35Z

Awesome, thanks for the help - I will fix the date @hieronx

hieronx · 2024-07-28T17:48:15Z

Seeing it now in action, a few more small comments:

Let's remove the ID column, it doesn't add any useful information
Would be great to make the Name column values clickable, going to the asset detail page (https://pr2289-app-ff-production.k-f.dev/#/pools/4139607887/assets/1)
Would be great to, by default, sort by maturity date such that the furthest date in the future is at the top. I tried this already but it doesn't seem to work correctly.

And two issues I noticed in the DYF pool (see https://pr2289-app-ff-production.k-f.dev/#/pools/1655476167/reporting/asset-list, put date to 27/7/24):

If the maturity date is undefined, it should state Open-end rather than Jan 1, 1970.
If the notional is undefined, let's show - in the Face value column rather than 0.00 USDC.

sophialittlejohn · 2024-07-29T22:41:23Z

Nice work! Also just tested it and noticed a few things:

the filters for active, repaid and overdue don't seem to work yet
some pools don't have data in the asset-list report despite having assets (e.g https://app-pr2289.k-f.dev/#/pools/3783931117/assets). The loans are only in "Created" state so I'm not sure if they should appear in the report or not?

kattylucy · 2024-07-30T13:33:44Z

The first one is definitely a bug, thanks for pointing out. The second question, I kept the previous logic regarding which loans to display, based on prev log we shouldn't display 'created' status loans. Do we want to change this? @hieronx @sophialittlejohn

hieronx · 2024-07-30T13:40:18Z

@kattylucy I would include Created assets if you select Status All, but make the default Status filter Ongoing. (and rename Active to Ongoing)

kattylucy · 2024-07-30T14:23:25Z

I apologize but it seems like the subquery only returns ongoing assets - is not returning 'created' assets at all

@sophialittlejohn
@hieronx

hieronx · 2024-07-30T14:26:50Z

Ah ok, then just leave them out. Would still default the status to Ongoing so repaid assets don't show up by default.

hieronx · 2024-07-30T15:49:49Z

@kattylucy looking great!

One more comment: could you change the quantity col formatting from 10,170.00 USDC to 10,170.00?

kattylucy · 2024-07-30T15:53:21Z

@hieronx Let me look into it! Thanks!!

kattylucy · 2024-07-30T19:16:53Z

One thing here, when clicking like this

reporting -> asset list report -> asset name

we go to the route for the specific asset. When clicking back, it takes me to the asset list instead of the table for reporting, should we change the behavior so the back button takes back to the prev page based on the user last page?

hope my question makes sense

@hieronx

hieronx · 2024-07-30T19:21:25Z

we go to the route for the specific asset. When clicking back, it takes me to the asset list instead of the table for reporting, should we change the behavior so the back button takes back to the prev page based on the user last page?

Good point. Seems to make sense to me to change it like you suggest. @sophialittlejohn any thoughts?

hieronx · 2024-07-31T11:31:41Z

@kattylucy two more comments from latest check:

The sorting by maturity date doesn't seem to fully work yet.

Also, when the face value is undefined, can you change it to -? It should only show 0.0 if it is actually 0, not if it is undefined and thus does not apply. As seen on https://pr2289-app-ff-production.k-f.dev/#/pools/1655476167/reporting/asset-list.

kattylucy · 2024-07-31T20:10:38Z

@hieronx do you mind sending me the pool and the date you are using so I can confirm the issues? having a hard time reproducing the errors - thank you!

hieronx · 2024-07-31T20:33:11Z

The face value I tested on https://pr2289-app-ff-production.k-f.dev/#/pools/1655476167/reporting/asset-list, with today's date.

The maturity dates I tested on https://pr2289-app-ff-production.k-f.dev/#/pools/4139607887/reporting/asset-list, also with today's date.

hieronx

Looks great to me!

onnovisser · 2024-08-05T08:58:47Z

centrifuge-js/src/types/subquery.ts

@@ -144,22 +144,36 @@ export type SubqueryAssetTransaction = {
 export type SubqueryAssetSnapshot = {
  __typename?: 'AssetSnapshot'
  asset: {
+    actualOriginationDate: number


The Subquery never returns Rates or CurrencyBalances so this type is now misleading. getAssetSnapshots also uses this type and doesn't return any of the new additions, so consumers of that function may now expect values to be there that aren't there. I would suggest creating separate SubqueryPoolAssetSnapshot and PoolAssetSnapshot types to have the functions accurately reflect what they return

onnovisser · 2024-08-05T09:00:52Z

centrifuge-app/src/components/Report/AssetList.tsx

@@ -182,12 +296,15 @@ export function AssetList({ pool }: { pool: Pool }) {
      setCsvData(undefined)
      URL.revokeObjectURL(dataUrl)
    }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [data])
+  }, [snapshots])


some lint warnings in this file. for this line it's fine to disable

onnovisser · 2024-08-05T09:03:01Z

centrifuge-app/src/components/Report/AssetList.tsx

-  React.useEffect(() => {
-    if (!data.length) {
+  useEffect(() => {
+    if (!snapshots?.length) {


why check for snapshots now and not data ? data may end up having no items because of the snapshots being filtered

onnovisser · 2024-08-05T09:04:40Z

centrifuge-app/src/components/Report/AssetList.tsx

+  const basePath = useBasePath()
+  const { loanStatus, startDate, setCsvData } = useContext(ReportContext)
+  const { data: poolMetadata } = usePoolMetadata(pool)
+  const poolCreditType = useMemo(() => poolMetadata?.pool?.asset.class || 'privateCredit', [poolMetadata])


I would only keep the useMemo for data, the others here do more harm than good

- Name should be a link to asset page - Undefined should display as '-' - Undefined maturity date should display as open-end - Data table should sort by default using maturity date desc - Remove id column

this is unrelated to this work but when running the linter I found two warning of unused values just a cleanup

kattylucy force-pushed the asset_list_report_update branch 3 times, most recently from 78419ee to 433f6d7 Compare July 23, 2024 20:13

kattylucy force-pushed the asset_list_report_update branch 3 times, most recently from c597118 to 38b9cc0 Compare July 25, 2024 18:24

kattylucy marked this pull request as ready for review July 25, 2024 18:24

kattylucy requested a review from onnovisser July 25, 2024 18:25

kattylucy force-pushed the asset_list_report_update branch from 9d31c90 to 137590d Compare July 30, 2024 15:21

kattylucy force-pushed the asset_list_report_update branch 2 times, most recently from e295e84 to 27809cc Compare July 30, 2024 19:10

kattylucy force-pushed the asset_list_report_update branch 2 times, most recently from 778e825 to b7d1dc4 Compare August 1, 2024 13:33

hieronx approved these changes Aug 5, 2024

View reviewed changes

onnovisser reviewed Aug 5, 2024

View reviewed changes

kattylucy force-pushed the asset_list_report_update branch from fc30639 to 788ced4 Compare August 5, 2024 16:12

kattylucy requested a review from onnovisser August 5, 2024 16:12

kattylucy force-pushed the asset_list_report_update branch 2 times, most recently from e6a8fa3 to f563a16 Compare August 5, 2024 16:32

kattylucy and others added 8 commits August 6, 2024 08:07

Add new subquery

d513eea

Add date picker to asset list report

6a5905c

Update asset list report component

9f7d5bc

Fix asset list for LTF (#2323)

acfa71c

Add feedback fixes

503e877

- Name should be a link to asset page - Undefined should display as '-' - Undefined maturity date should display as open-end - Data table should sort by default using maturity date desc - Remove id column

Refactor link component to allow going back to prev page

710fef7

Fix bug typo on poolCreditType

0f921a1

Fix TS errors

7c64d31

kattylucy force-pushed the asset_list_report_update branch from f563a16 to bcf0f74 Compare August 6, 2024 13:19

kattylucy added 2 commits August 6, 2024 08:57

Change ts types subquery to represent actual values

32799d4

Fix linter undeclared variables

4b4e7b5

this is unrelated to this work but when running the linter I found two warning of unused values just a cleanup

kattylucy force-pushed the asset_list_report_update branch from bcf0f74 to 4b4e7b5 Compare August 6, 2024 13:57

onnovisser approved these changes Aug 7, 2024

View reviewed changes

hieronx merged commit 732ea5f into main Aug 7, 2024
13 checks passed

hieronx deleted the asset_list_report_update branch August 7, 2024 06:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Asset list report update #2289

Asset list report update #2289

kattylucy commented Jul 18, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

hieronx commented Jul 28, 2024

kattylucy commented Jul 28, 2024

hieronx commented Jul 28, 2024

sophialittlejohn commented Jul 29, 2024

kattylucy commented Jul 30, 2024 •

edited

Loading

hieronx commented Jul 30, 2024 •

edited

Loading

kattylucy commented Jul 30, 2024

hieronx commented Jul 30, 2024

hieronx commented Jul 30, 2024

kattylucy commented Jul 30, 2024 •

edited

Loading

kattylucy commented Jul 30, 2024

hieronx commented Jul 30, 2024

hieronx commented Jul 31, 2024

kattylucy commented Jul 31, 2024

hieronx commented Jul 31, 2024

hieronx left a comment

onnovisser Aug 5, 2024

onnovisser Aug 5, 2024

onnovisser Aug 5, 2024

onnovisser Aug 5, 2024

Asset list report update #2289

Asset list report update #2289

Conversation

kattylucy commented Jul 18, 2024 • edited Loading

github-actions bot commented Jul 25, 2024 • edited Loading

github-actions bot commented Jul 25, 2024 • edited Loading

hieronx commented Jul 28, 2024

kattylucy commented Jul 28, 2024

hieronx commented Jul 28, 2024

sophialittlejohn commented Jul 29, 2024

kattylucy commented Jul 30, 2024 • edited Loading

hieronx commented Jul 30, 2024 • edited Loading

kattylucy commented Jul 30, 2024

hieronx commented Jul 30, 2024

hieronx commented Jul 30, 2024

kattylucy commented Jul 30, 2024 • edited Loading

kattylucy commented Jul 30, 2024

hieronx commented Jul 30, 2024

hieronx commented Jul 31, 2024

kattylucy commented Jul 31, 2024

hieronx commented Jul 31, 2024

hieronx left a comment

Choose a reason for hiding this comment

onnovisser Aug 5, 2024

Choose a reason for hiding this comment

onnovisser Aug 5, 2024

Choose a reason for hiding this comment

onnovisser Aug 5, 2024

Choose a reason for hiding this comment

onnovisser Aug 5, 2024

Choose a reason for hiding this comment

kattylucy commented Jul 18, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024 •

edited

Loading

kattylucy commented Jul 30, 2024 •

edited

Loading

hieronx commented Jul 30, 2024 •

edited

Loading

kattylucy commented Jul 30, 2024 •

edited

Loading