Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YTM in asset details #2116

Merged
merged 9 commits into from
May 17, 2024
Merged

YTM in asset details #2116

merged 9 commits into from
May 17, 2024

Conversation

sophialittlejohn
Copy link
Collaborator

Description

This pull request...

  • renames face flow to face value
  • adds YTM (yield to maturity?) to transaction table on asset detail page
  • adds weighted average YTM to asset detail summary

--> to test look at Anemoy assets

#2111

Approvals

  • Dev
  • Dev
  • Designer
  • Product

Screenshots

Impact

Copy link

github-actions bot commented May 6, 2024

PR deployed in Google Cloud
URL: https://app-pr2116.k-f.dev
Commit #: 3eb00dc
To access the functions directly check the corresponding deploy Action

Copy link

github-actions bot commented May 6, 2024

PR deployed in Google Cloud
URL: https://pr2116-app-ff-production.k-f.dev
Commit #: 3eb00dc
To access the functions directly check the corresponding deploy Action

@@ -129,8 +157,8 @@ export const TransactionTable = ({ transactions, currency, loanType, decimals, p
align: 'left',
header: `Face flow (${currency})`,
Copy link
Collaborator

@onnovisser onnovisser May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table heading is still named Face flow

Copy link
Contributor

@jpangelle jpangelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! (after addressing Onno's feedback)

@sophialittlejohn sophialittlejohn merged commit 31dd5da into main May 17, 2024
10 checks passed
@sophialittlejohn sophialittlejohn deleted the ytm-in-asset-detail branch May 17, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants