Refactor publishing to Maven Central #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntoskrnl
commented
Aug 23, 2022
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-bin.zip |
There was a problem hiding this comment.
Had to upgrade Gradle (min required version is 7.2.0)
Now it is probably required to use JDK 11 to build the library (but I'm not sure). Shouldn't affect anything else, only the compilation.
ntoskrnl
force-pushed
the
publishing-plugin
branch
from
f274f2a to
44a77d3
Compare
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use plugin: https://github.com/vanniktech/gradle-maven-publish-plugin
It's a wrapper around Gradle Maven Publish plugin that makes publishing to Maven Central easier. Many open-source libraries have moved to it, for example Accompanist, OkHttp and others.
Why do we need this?
For this library it mainly brings ability to publish to Maven Central from command line without having to go to the Sonatype website.
This is a step towards automated releases via Github Actions.
There are 2 ways to configure it. I currently do it dynamically via base plugin config in
publish-setup.gradleand then in each published modulebuild.gradle.I think we might rewrite it into using Gradle properties (there are more examples of it in other OSS projects). But for now it should already work.