docs(ns-table): add a11y attr info#829
Open
evecrabb wants to merge 5 commits into
Open
Conversation
- add detail about attributes to improve a11y - update the existing examples to use `scope` attr
Deploying nucleus-docs with
|
| Latest commit: |
40a2dd1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1b0a51e3.nucleus-docs.pages.dev |
| Branch Preview URL: | https://a11y-document-table-markup-g.nucleus-docs.pages.dev |
This, I have now learnt, is generated automatically by the component, so this change can be reverted
- move guidance around attrs and ids to specification section as instructed - update guidance to read better - add guidance around visually-hidden approach
Now that we're using a span inside the th, it makes sense to refine this a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improving a11y guidance for
ns-tableFollowing the update to the Stories in Nucleus, this is a nice addition.
Summary of changes