Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mon 15407 add protobuf instance status message #405

Conversation

jean-christophe81
Copy link
Contributor

Description

add pb_instance_status

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@jean-christophe81 jean-christophe81 force-pushed the MON-15407-add-protobuf-instance_status-message branch from dd2c43c to 655f79f Compare October 13, 2022 15:09
throw msg_fmt("unknwown protobuf class com.centreon.broker.{}",
info->get_name());
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have written an assert()

@sonarqube-decoration
Copy link

@jean-christophe81 jean-christophe81 merged commit f438f81 into develop-pending Oct 13, 2022
@jean-christophe81 jean-christophe81 deleted the MON-15407-add-protobuf-instance_status-message branch October 13, 2022 15:23
jean-christophe81 added a commit that referenced this pull request Oct 17, 2022
* MON-15407-add-protobuf-instance_status-message
REFS:MON-15407
jean-christophe81 added a commit that referenced this pull request Oct 17, 2022
* MON-15407-add-protobuf-instance_status-message
REFS:MON-15407
jean-christophe81 added a commit that referenced this pull request Oct 17, 2022
* MON-15407-add-protobuf-instance_status-message
REFS:MON-15407
jean-christophe81 added a commit that referenced this pull request Oct 17, 2022
* Mon 15406 add protobuf instance message
REFS:MON-15406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants