Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-14511-poller-wait-at-most-5s-to-send-shutdown-event-before-shutdown #351

Conversation

jean-christophe81
Copy link
Contributor

Description

When you have a poller on a server with one core and a cbd on another server, if you shutdown engine, cbd don't receive engine bye message
So I have added wait methods on grpc and tcp modules and an usleep on config::applier::endpoint::_discard to wait one loop of failover and feeders threads.
Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

How this pull request can be tested ?

In order to test install a poller on a one core VM, insall a cbd on another VM. In the poller screen, you have to see the poller shutdown when you shurdown the distant poller.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@jean-christophe81 jean-christophe81 force-pushed the MON-14511-poller-dont-send-always-bye-to-broker-22-10 branch from 41a9a83 to 36265be Compare September 5, 2022 08:56
@jean-christophe81 jean-christophe81 force-pushed the MON-14511-poller-dont-send-always-bye-to-broker-22-10 branch from 36265be to 6300aa3 Compare September 7, 2022 12:50
@sonarqube-decoration
Copy link

@jean-christophe81 jean-christophe81 merged commit 74e5bad into develop Sep 7, 2022
@jean-christophe81 jean-christophe81 deleted the MON-14511-poller-dont-send-always-bye-to-broker-22-10 branch September 7, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants