Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(sonar): replace new by shared_ptr in engine downtimes #347

Merged
merged 10 commits into from
Sep 5, 2022
Merged

enh(sonar): replace new by shared_ptr in engine downtimes #347

merged 10 commits into from
Sep 5, 2022

Conversation

denliA
Copy link
Contributor

@denliA denliA commented Aug 18, 2022

#REFS: MON-14588
enh(sonar): replace new by shared_ptr in engine downtimes

Description

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@denliA denliA force-pushed the MON-14588-sonar-downtime branch from 0df37e7 to d09b648 Compare August 31, 2022 13:41
@bouda1 bouda1 force-pushed the MON-14588-sonar-downtime branch from d09b648 to 393fbc9 Compare August 31, 2022 14:12
@denliA denliA force-pushed the MON-14588-sonar-downtime branch from 393fbc9 to d09b648 Compare August 31, 2022 14:21
@bouda1 bouda1 force-pushed the MON-14588-sonar-downtime branch from d09b648 to 8cfc94a Compare August 31, 2022 14:30
@bouda1 bouda1 force-pushed the MON-14588-sonar-downtime branch 2 times, most recently from fe8ade0 to 3398326 Compare September 3, 2022 19:42
@bouda1 bouda1 force-pushed the MON-14588-sonar-downtime branch from 3398326 to 931d807 Compare September 5, 2022 07:20
@sonarqube-decoration
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 12 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bouda1 bouda1 merged commit e46c577 into develop Sep 5, 2022
@bouda1 bouda1 deleted the MON-14588-sonar-downtime branch September 5, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jean-christophe81 jean-christophe81 jean-christophe81 left review comments

@bouda1 bouda1 bouda1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denliA @bouda1 @jean-christophe81