Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(ci): add debian12 arm builds and tests triggers #1281

Merged
merged 9 commits into from
Apr 23, 2024

Conversation

tuntoja
Copy link
Contributor

@tuntoja tuntoja commented Apr 18, 2024

Description

  • add debian 12 + ARM collect build & packaging

Fixes #MON-55163

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • master

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

Summary by CodeRabbit

  • Chores
    • Removed the unit-test job from the workflow to streamline operations.
  • New Features
    • Added support for ARM64 architecture in Docker builds and packaging, specifically for Debian Bookworm.
    • Introduced a new test configuration for bookworm with mariadb on arm64 architecture in the nightly workflow.
    • Updated runner configuration for collect-arm64 with corresponding Dockerfile, image, and tag.

@tuntoja tuntoja requested a review from a team as a code owner April 18, 2024 12:59
Copy link
Contributor

coderabbitai bot commented Apr 18, 2024

Walkthrough

Enhancements in the GitHub workflows now include ARM64 support for Docker builds and testing configurations for Debian Bookworm in the docker-builder.yml workflow. These changes boost compatibility and testing capabilities for the project.

Changes

File Path Change Summary
.github/workflows/docker-builder.yml Added collect-arm64 runner config for Debian Bookworm.

🐰✨
A hop, a skip, a code deploy,
New paths we tread, oh what a joy!
ARM64, now you're in the loop,
With Bookworm snug in our troop.
Changes big, changes small,
Celebrate we shall, one and all!
🌟🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tuntoja tuntoja changed the title Mon 55163 add debian12 arm builds enh(ci): add debian12 arm builds Apr 19, 2024
@tuntoja tuntoja changed the title enh(ci): add debian12 arm builds enh(ci): add debian12 arm builds and tests triggers Apr 19, 2024
Copy link
Contributor Author

@tuntoja tuntoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuntoja make sure to revert any test previously disabled to their original state

@tuntoja tuntoja marked this pull request as draft April 19, 2024 13:02
@tuntoja tuntoja marked this pull request as ready for review April 23, 2024 09:15
@tuntoja tuntoja requested a review from kduret April 23, 2024 09:16
@tuntoja tuntoja merged commit 34feab0 into develop Apr 23, 2024
2 checks passed
@tuntoja tuntoja deleted the MON-55163-add-debian12-arm-builds branch April 23, 2024 09:51
tuntoja added a commit that referenced this pull request Apr 23, 2024
* add debian 12 arm build

* add debian 12 arm build

* add packaging matrix

* add dockerfile for deb12 arm64

* fix docker builder workflow

* fix package collect missing letter

* fix robot nightly debian 12 arm

* fix tag for bookworm arm64 test image version

* restore unit-tests
tuntoja added a commit that referenced this pull request Apr 23, 2024
* add debian 12 arm build

* add debian 12 arm build

* add packaging matrix

* add dockerfile for deb12 arm64

* fix docker builder workflow

* fix package collect missing letter

* fix robot nightly debian 12 arm

* fix tag for bookworm arm64 test image version

* restore unit-tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants