Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(ci): deliver develop packages to cloud internal repositories #1279

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

tuntoja
Copy link
Contributor

@tuntoja tuntoja commented Apr 15, 2024

Description

depending on get-versions release_cloud output

deliver testing packages to internal repositories (release or hotfix) or to onprem repositories (testing)
deliver unstable packages to internal repositories or to onprem repositories

Fixes #MON-52724

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • master

Summary by CodeRabbit

  • New Features
    • Improved release delivery process to handle various scenarios including hotfixes and development changes.
    • Enhanced versioning system to automatically set release information for the develop branch.

@tuntoja tuntoja requested a review from a team as a code owner April 15, 2024 13:46
Copy link
Contributor

coderabbitai bot commented Apr 15, 2024

Walkthrough

The recent updates enhance the delivery process by tailoring actions based on the type of release and the operational environment, specifically differentiating between cloud scenarios and others. Additionally, the workflow now includes logic to handle versioning more effectively for the develop branch, ensuring accurate release information is set up.

Changes

File Path Change Summary
.github/actions/delivery/action.yml Updated to handle various scenarios including cloud and non-cloud conditions, adjusting paths accordingly.
.github/workflows/get-version.yml Added logic to set release info for the develop branch based on branch name and GitHub variables.

🐰✨
In the burrows of the code, beneath the digital sky,
A rabbit hopped through branches, with a twinkle in its eye.
"A tweak here, a fix there," it mused with glee,
"For every type of release, as versatile as can be!"
🌟📦


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4966ea3 and eac2770.
Files selected for processing (1)
  • .github/actions/delivery/action.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/actions/delivery/action.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

.github/actions/delivery/action.yml Outdated Show resolved Hide resolved
@tuntoja tuntoja changed the title enh(ci): update cloud delivery enh(ci): deliver develop packages to cloud internal repositories Apr 16, 2024
@tuntoja tuntoja merged commit 7123790 into develop Apr 17, 2024
2 checks passed
@tuntoja tuntoja deleted the MON-52724-update-develop-delivery-to-internal branch April 17, 2024 12:01
jean-christophe81 pushed a commit that referenced this pull request May 3, 2024
* enh(ci): update cloud delivery

* Refine conditional logic
jean-christophe81 pushed a commit that referenced this pull request May 15, 2024
* enh(ci): update cloud delivery

* Refine conditional logic
jean-christophe81 pushed a commit that referenced this pull request May 15, 2024
* enh(ci): update cloud delivery

* Refine conditional logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants