Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): prepare 24.05.0 #1278

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

tuntoja
Copy link
Contributor

@tuntoja tuntoja commented Apr 12, 2024

Description

  • bump collect to 24.05.0

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x
  • 24.05.x (master)

Summary by CodeRabbit

  • Chores
    • Updated the minor version number from 04 to 05 in the CMakeLists.txt file.
    • Updated version checkboxes in the pull request template.
    • Incremented the major version number from 24.04 to 24.05.

@tuntoja tuntoja requested a review from a team as a code owner April 12, 2024 15:00
Copy link
Contributor

coderabbitai bot commented Apr 12, 2024

Walkthrough

The recent adjustments in the project involve minor version increments and template updates. The CMakeLists.txt file sees the COLLECT_MINOR version move from 04 to 05, while the .version file increments the major version from 24.04 to 24.05. Additionally, the pull request template in .github/PULL_REQUEST_TEMPLATE.md now includes checkboxes for 24.04.x and master, enhancing version tracking and compatibility.

Changes

File Change Summary
CMakeLists.txt Updated COLLECT_MINOR version from 04 to 05
.version Incremented major version from 24.04 to 24.05
.github/PULL_REQUEST_TEMPLATE.md Added checkboxes for 24.04.x and master versions

🐇✨
A leap in versions, a dance of code,
From twenty-four dot zero four, to twenty-four dot zero five we rode.
Checkboxes new, and numbers grow,
Progress whispers, in each line's flow.
Hop, hop, hurray! Forward we go! 🚀🌟
🐇✨


Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 27f2266 and 6dd7f7c.
Files selected for processing (2)
  • .github/PULL_REQUEST_TEMPLATE.md (1 hunks)
  • .version (1 hunks)
Files skipped from review due to trivial changes (1)
  • .version
Additional comments not posted (1)
.github/PULL_REQUEST_TEMPLATE.md (1)

19-26: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [11-37]

Change list item markers from dashes to asterisks for consistency with typical Markdown style.

- - [ ] Patch fixing an issue (non-breaking change)
+ * [ ] Patch fixing an issue (non-breaking change)
- - [ ] New functionality (non-breaking change)
+ * [ ] New functionality (non-breaking change)
- - [ ] Breaking change (patch or feature) that might cause side effects breaking part of the Software
+ * [ ] Breaking change (patch or feature) that might cause side effects breaking part of the Software
- - [ ] Updating documentation (missing information, typo...)
+ * [ ] Updating documentation (missing information, typo...)
- - [ ] 22.04.x
+ * [ ] 22.04.x
- - [ ] 22.10.x
+ * [ ] 22.10.x
- - [ ] 23.04.x
+ * [ ] 23.04.x
- - [ ] 23.10.x
+ * [ ] 23.10.x
- - [ ] 24.04.x
+ * [ ] 24.04.x
- - [ ] master
+ * [ ] master
- - [ ] I have followed the **coding style guidelines** provided by Centreon
+ * [ ] I have followed the **coding style guidelines** provided by Centreon
- - [ ] I have commented my code, especially new **classes**, **functions** or any **legacy code** modified. (***docblock***)
+ * [ ] I have commented my code, especially new **classes**, **functions** or any **legacy code** modified. (***docblock***)
- - [ ] I have commented my code, especially **hard-to-understand areas** of the PR.
+ * [ ] I have commented my code, especially **hard-to-understand areas** of the PR.
- - [ ] I have made corresponding changes to the **documentation**.
+ * [ ] I have made corresponding changes to the **documentation**.
- - [ ] I have **rebased** my development branch on the base branch (master, maintenance).
+ * [ ] I have **rebased** my development branch on the base branch (master, maintenance).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tuntoja tuntoja force-pushed the MON-52724-prepare-24-04-0-onprem-and-24-05-0-cloud branch from e2b9e18 to 27f2266 Compare April 17, 2024 12:54
@tuntoja tuntoja requested a review from a team as a code owner April 17, 2024 13:04
@tuntoja tuntoja merged commit 1da1ab1 into develop Apr 17, 2024
2 checks passed
@tuntoja tuntoja deleted the MON-52724-prepare-24-04-0-onprem-and-24-05-0-cloud branch April 17, 2024 13:06
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Actionable comments outside the diff hunks (1)
.github/PULL_REQUEST_TEMPLATE.md (1)

Line range hint 39-39: Remove one of the consecutive blank lines at the end of the file to adhere to best practices.

- 

Comment on lines +22 to +23
- [ ] 24.04.x
- [ ] master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a blank line before the list of version checkboxes to maintain consistency and improve readability.

+ 
- [ ] 24.04.x
- [ ] master

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
- [ ] 24.04.x
- [ ] master
- [ ] 24.04.x
- [ ] master

@tuntoja tuntoja restored the MON-52724-prepare-24-04-0-onprem-and-24-05-0-cloud branch May 2, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants