Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(promote): handle debian package promotion for multiple distributions #1276

Conversation

tuntoja
Copy link
Contributor

@tuntoja tuntoja commented Apr 10, 2024

Description

minor fixes
add support for multiple debian distributions to promote action

Fixes #MON-51089

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x (master)

@tuntoja tuntoja requested a review from a team as a code owner April 10, 2024 12:00
@tuntoja tuntoja requested review from kduret and sc979 April 10, 2024 12:00
Copy link
Contributor

coderabbitai bot commented Apr 10, 2024

Warning

Rate Limit Exceeded

@tuntoja has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 40 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between e13e2e3 and 03e6058.

Walkthrough

The recent update to the script for promoting DEB packages enhances functionality by integrating additional debug outputs for better tracking and validation. It now includes criteria for version and distribution matching, ensuring that only the correct packages are promoted to stable based on the specified distribution.

Changes

File Path Change Summary
.github/.../promote-to-stable/action.yml Updated to add debug outputs for versions and distribution, and to include version and distribution matching criteria in the search for DEB packages. Added a check to ensure distribution alignment before promotion.

Poem

🐇💻
In the burrows of the code, where the bits do roam,
A script was tweaked, in its digital home.
Debugs now dance with versions in hand,
Ensuring the stable lands as planned.
Oh, how the packets align just right,
Under the moon's soft, silvery light.
🌕📦


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Co-authored-by: Kevin Duret <kduret@centreon.com>
@tuntoja tuntoja merged commit b3fa0e7 into develop Apr 22, 2024
2 checks passed
@tuntoja tuntoja deleted the MON-51089-handle-multiple-debian-distrib-input-in-promote-actions branch April 22, 2024 15:05
tuntoja added a commit that referenced this pull request Apr 23, 2024
…ons (#1276)

* enh(promote): handle debian package promotion for multiple distributions

* Update .github/actions/promote-to-stable/action.yml

Co-authored-by: Kevin Duret <kduret@centreon.com>

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>
tuntoja added a commit that referenced this pull request Apr 23, 2024
…ons (#1276)

* enh(promote): handle debian package promotion for multiple distributions

* Update .github/actions/promote-to-stable/action.yml

Co-authored-by: Kevin Duret <kduret@centreon.com>

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>
tuntoja added a commit that referenced this pull request Apr 23, 2024
…ons (#1276)

* enh(promote): handle debian package promotion for multiple distributions

* Update .github/actions/promote-to-stable/action.yml

Co-authored-by: Kevin Duret <kduret@centreon.com>

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>
tuntoja added a commit that referenced this pull request Apr 23, 2024
…ons (#1276)

* enh(promote): handle debian package promotion for multiple distributions

* Update .github/actions/promote-to-stable/action.yml

Co-authored-by: Kevin Duret <kduret@centreon.com>

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>
tuntoja added a commit that referenced this pull request Apr 23, 2024
…ons (#1276)

* enh(promote): handle debian package promotion for multiple distributions

* Update .github/actions/promote-to-stable/action.yml

Co-authored-by: Kevin Duret <kduret@centreon.com>

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>
tuntoja added a commit that referenced this pull request Apr 24, 2024
#1296)

* enh(promote): handle debian package promotion for multiple distributions (#1276)

* enh(promote): handle debian package promotion for multiple distributions

* Update .github/actions/promote-to-stable/action.yml

Co-authored-by: Kevin Duret <kduret@centreon.com>

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>

* incomplete condition on distribution

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>
Co-authored-by: May <110405507+paul-oureib@users.noreply.github.com>
tuntoja added a commit that referenced this pull request Apr 24, 2024
#1295)

* enh(promote): handle debian package promotion for multiple distributions (#1276)

* enh(promote): handle debian package promotion for multiple distributions

* Update .github/actions/promote-to-stable/action.yml

Co-authored-by: Kevin Duret <kduret@centreon.com>

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>

* incomplete condition on distribution

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>
Co-authored-by: May <110405507+paul-oureib@users.noreply.github.com>
tuntoja added a commit that referenced this pull request Apr 24, 2024
#1294)

* enh(promote): handle debian package promotion for multiple distributions (#1276)

* enh(promote): handle debian package promotion for multiple distributions

* Update .github/actions/promote-to-stable/action.yml

Co-authored-by: Kevin Duret <kduret@centreon.com>

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>

* incomplete condition on distribution

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>
Co-authored-by: May <110405507+paul-oureib@users.noreply.github.com>
tuntoja added a commit that referenced this pull request Apr 24, 2024
#1293)

* enh(promote): handle debian package promotion for multiple distributions (#1276)

* enh(promote): handle debian package promotion for multiple distributions

* Update .github/actions/promote-to-stable/action.yml

Co-authored-by: Kevin Duret <kduret@centreon.com>

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>

* condition on distribution incomplete

---------

Co-authored-by: Kevin Duret <kduret@centreon.com>
Co-authored-by: May <110405507+paul-oureib@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants