fix(ci): fix release pipelines issues #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Auto Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
.github/actions/delivery/action.yml
Outdated
| @@ -116,7 +116,7 @@ runs: | |||
| if [ "${{ inputs.stability }}" == "stable" ]; then | |||
| echo "[DEBUG] - Stability is ${{ inputs.stability }}, not delivering." | |||
| else | |||
| jf rt upload "$ARCH/*.rpm" "$ROOT_REPO_PATH/$UPLOAD_REPO_PATH" --sync-deletes="$ROOT_REPO_PATH/$UPLOAD_REPO_PATH" --flat | |||
| jf rt upload "$ARCH/*.rpm" "$ROOT_REPO_PATH/$UPLOAD_REPO_PATH" --sync-deletes="$ROOT_REPO_PATH/$UPLOAD_REPO_PATH" --sync-deletes="$ROOT_REPO_PATH/$UPLOAD_REPO_PATH/"--flat | |||
There was a problem hiding this comment.
Suggested change
| jf rt upload "$ARCH/*.rpm" "$ROOT_REPO_PATH/$UPLOAD_REPO_PATH" --sync-deletes="$ROOT_REPO_PATH/$UPLOAD_REPO_PATH" --sync-deletes="$ROOT_REPO_PATH/$UPLOAD_REPO_PATH/"--flat | |
| jf rt upload "$ARCH/*.rpm" "$ROOT_REPO_PATH/$UPLOAD_REPO_PATH" --sync-deletes="$ROOT_REPO_PATH/$UPLOAD_REPO_PATH" --flat |
| github_base_ref: | ||
| description: "Release base ref" | ||
| github_ref_name: | ||
| description: "Release base ref name for push event" |
There was a problem hiding this comment.
Suggested change
| description: "Release base ref name for push event" | |
| description: "Release base ref name for push event" |
| # Build search path based on release_cloud and release_type values | ||
| # if cloud, search in testing-<release_type> path | ||
| # if non-cloud, search in the testing usual path | ||
| if [[ ${{ inputs.release_cloud }} -eq 1 && ${{ inputs.release_type }} == "hotfix" ]] || [[ ${{ inputs.release_cloud }} -eq 1 && ${{ inputs.release_type }} == "release" ]];then |
There was a problem hiding this comment.
Suggested change
| if [[ ${{ inputs.release_cloud }} -eq 1 && ${{ inputs.release_type }} == "hotfix" ]] || [[ ${{ inputs.release_cloud }} -eq 1 && ${{ inputs.release_type }} == "release" ]];then | |
| if [[ ${{ inputs.release_cloud }} -eq 1 && ${{ inputs.release_type }} == "hotfix" ]] || [[ ${{ inputs.release_cloud }} -eq 1 && ${{ inputs.release_type }} == "release" ]]; then |
| # if non-cloud, search in the testing usual path | ||
| if [[ ${{ inputs.release_cloud }} -eq 1 && ${{ inputs.release_type }} == "hotfix" ]] || [[ ${{ inputs.release_cloud }} -eq 1 && ${{ inputs.release_type }} == "release" ]];then | ||
| SEARCH_REPO_PATH="${{ inputs.major_version }}/${{ inputs.distrib }}/testing-${{ inputs.release_type }}/$ARCH/${{ inputs.module_name }}" | ||
| elif [[ ${{ inputs.release_cloud }} -eq 0 ]];then |
There was a problem hiding this comment.
Suggested change
| elif [[ ${{ inputs.release_cloud }} -eq 0 ]];then | |
| elif [[ ${{ inputs.release_cloud }} -eq 0 ]]; then |
kduret
approved these changes
Apr 2, 2024
mushroomempires
approved these changes
Apr 2, 2024
tuntoja
added a commit
that referenced
this pull request
Apr 2, 2024
* fix(ci): fix release pipelines issues * fix(ci): fix libzmq promote input * fix invalid rpm promote command
tuntoja
added a commit
that referenced
this pull request
Apr 2, 2024
* fix(ci): fix release pipelines issues * fix(ci): fix libzmq promote input * fix invalid rpm promote command
tuntoja
added a commit
that referenced
this pull request
Apr 2, 2024
* fix(ci): fix release pipelines issues * fix(ci): fix libzmq promote input * fix invalid rpm promote command
tuntoja
added a commit
that referenced
this pull request
Apr 2, 2024
* fix(ci): fix release pipelines issues * fix(ci): fix libzmq promote input * fix invalid rpm promote command
jean-christophe81
pushed a commit
that referenced
this pull request
May 3, 2024
* fix(ci): fix release pipelines issues * fix(ci): fix libzmq promote input * fix invalid rpm promote command
jean-christophe81
pushed a commit
that referenced
this pull request
May 15, 2024
* fix(ci): fix release pipelines issues * fix(ci): fix libzmq promote input * fix invalid rpm promote command
jean-christophe81
pushed a commit
that referenced
this pull request
May 15, 2024
* fix(ci): fix release pipelines issues * fix(ci): fix libzmq promote input * fix invalid rpm promote command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix additional issues resulting from previous conflicts resolution and PRs
use github_ref_name on push even instead of github_base_ref
use proper path in promote search loop
Fixes #MON-35276
Type of change
Target serie
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.
Any relevant details of the configuration to perform the test should be added.
Checklist