Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fix release workflow and action issues #1223

Merged
merged 4 commits into from
Mar 29, 2024
Merged

fix(ci): fix release workflow and action issues #1223

merged 4 commits into from
Mar 29, 2024

Conversation

tuntoja
Copy link
Contributor

@tuntoja tuntoja commented Mar 26, 2024

Description

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes #MON-35276

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

tuntoja and others added 4 commits March 26, 2024 09:33
@tuntoja @mushroomempires
fix(ci): handle concurrent hotfix and release (#1191)
e6bfbff 
* fix(ci): handle concurrent hotfix and release

* fixed missing inputs in nightly and libzmq workflow

* Update action.yml

---------

Co-authored-by: May <110405507+paul-oureib@users.noreply.github.com>
@tuntoja
fix(delivery): fix missing inputs for rpm split delivery (#1195)
74fddc6
@tuntoja
fix(delivery): use root_repo_paths instead of fixed values (#1196)
0536a39
@tuntoja
fix(ci): fix release workflow and action issues (#1214)
03c5fea 
* fix(ci): fix release workflow and action issues

* use jira_base_url input

* fix
@tuntoja tuntoja requested a review from a team as a code owner March 26, 2024 08:35
@tuntoja tuntoja requested review from kduret and sc979 and removed request for a team March 26, 2024 08:35
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 26, 2024

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@tuntoja tuntoja merged commit ce67fa6 into dev-23.04.x Mar 29, 2024
73 checks passed
@tuntoja tuntoja deleted the MON-35276-fix-release-pipeline-to-handle-concurrent-hotfix-and-release-2304 branch March 29, 2024 10:09
kduret pushed a commit that referenced this pull request Jun 24, 2024
@garnier-quentin
enh(gorgone-svc-disco): can change macro before the service name crea… (
3b45658 
#1223)
kduret pushed a commit that referenced this pull request Jul 10, 2024
@garnier-quentin
enh(gorgone-svc-disco): can change macro before the service name crea… (
a53346d 
#1223)
kduret pushed a commit that referenced this pull request Jul 10, 2024
@garnier-quentin
enh(gorgone-svc-disco): can change macro before the service name crea… (
4290aba 
#1223)
kduret pushed a commit that referenced this pull request Jul 11, 2024
@garnier-quentin
enh(gorgone-svc-disco): can change macro before the service name crea… (
8e7e72a 
#1223)
kduret pushed a commit that referenced this pull request Jul 11, 2024
@garnier-quentin
enh(gorgone-svc-disco): can change macro before the service name crea… (
e6ca7d8 
#1223)
Evan-Adam pushed a commit that referenced this pull request Jul 16, 2024
@garnier-quentin @Evan-Adam
enh(gorgone-svc-disco): can change macro before the service name crea… (
340f873 
#1223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc979 sc979 sc979 approved these changes

@kduret kduret kduret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuntoja @kduret @sc979