Update for Compatibility with Docker Compose v2 #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request has been created because I found some errors installing TRAM container images with Docker Compose v2.
(1) docker-compose: No such file or directory
This error occurs when starting TRAM container images from the
start-container
task in Makefile.For the error details, see the following:
$ make start-container docker-compose -f docker/docker-compose.yml up -d make: docker-compose: No such file or directory make: *** [start-container] Error 1
It uses Docker Compose version v2.29.7 which is installed by Docker Desktop on Mac.
The recommended command-line syntax for Docker Compose v2 is
docker compose
.https://docs.docker.com/compose/releases/migrate/#what-are-the-differences-between-compose-v1-and-compose-v2
This Pull Request changes the compose command to replace
docker-compose
withdocker compose
.Additional information
The following Wiki page will also need similar changes.
(If this PR is merged, please update the Wiki accordingly.)
https://github.com/center-for-threat-informed-defense/tram/wiki/Installation
(2) Compose file: Version top-level element (obsolete)
This warning occurs when starting TRAM container images using
docker/docker-compose.yml
.The warning details following:
$ docker compose up WARN[0000] /Users/username/tram-docker/docker-compose.yml: the attribute `version` is obsolete, it will be ignored, please remove it to avoid potential confusion
The cause is that the version attribute has been obsoleted.
https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete
This Pull Request changes to remove the obsolete attribute of
version
.