This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Attach rate metrics for VM#935
Merged
lzchen merged 6 commits intocensus-instrumentation:masterfrom Jul 23, 2020
Merged
Conversation
lzchen
requested review from
a team,
aabmass,
c24t,
hectorhdzg,
reyang and
songy23
as code owners
hectorhdzg
reviewed
Jul 22, 2020
| response = requests.get(request_url, headers={"MetaData": "True"}) | ||
| except requests.exceptions.ConnectionError: | ||
| # Not in VM | ||
| self.is_vm = False |
There was a problem hiding this comment.
Is connection error enough to determine is not a VM?, maybe adding generic except as well to be sure doesn't think is a VM
Contributor
Author
There was a problem hiding this comment.
You are correct about the second except. I'll add it to catch anything else.
hectorhdzg
reviewed
Jul 22, 2020
| self.properties.clear() | ||
| self.update_properties() | ||
| self.heartbeat.clear() | ||
| # pylint: disable=protected-access |
There was a problem hiding this comment.
Is no other way to update the label keys value?, maybe creating the LongGauge again?
Contributor
Author
There was a problem hiding this comment.
I was thinking that maybe this would eventually take up too much memory, but Python gc is pretty efficient so we can do it this way.
hectorhdzg
approved these changes
Jul 22, 2020
hectorhdzg
left a comment
hectorhdzg
left a comment
There was a problem hiding this comment.
LGTM, just minor not blocking comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of [#930].
Detects whether current app is hosted in an Azure VM. We utilize AzureMetaDataService to retrieve vm information. We need to periodically retrieve this (not only on load) because this information can change.