Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

bump context version dependency#933

Merged
lzchen merged 5 commits intocensus-instrumentation:v0.7.xfrom
lzchen:version
Jul 21, 2020
Merged

bump context version dependency#933
lzchen merged 5 commits intocensus-instrumentation:v0.7.xfrom
lzchen:version

Conversation

@lzchen
Copy link
Contributor

@lzchen lzchen commented Jul 20, 2020

Fixes [#931]

Also adds missing test cases.

@lzchen lzchen requested review from a team, c24t, reyang and songy23 as code owners July 20, 2020 15:59
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +155 to +157
standard_metrics. \
http_requests. \
ORIGINAL_CONSTRUCTOR = lambda x, y, z: None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion on formatting, but it might be too wide?

Suggested change
standard_metrics. \
http_requests. \
ORIGINAL_CONSTRUCTOR = lambda x, y, z: None
standard_metrics.http_requests.ORIGINAL_CONSTRUCTOR = (
lambda x, y, z: None
)

Co-authored-by: Aaron Abbott <aaronabbott@google.com>
@lzchen lzchen merged commit 49b0cf9 into census-instrumentation:v0.7.x Jul 21, 2020
@lzchen lzchen deleted the version branch July 21, 2020 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants