Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Exporter/Metrics/OcAgent: Add export RPC handler and tests. #1630

Merged

Conversation

songy23
Copy link
Contributor

@songy23 songy23 commented Dec 4, 2018

Blocked by #1627.

Updates #1567.
Similar RPC handler to #1570.

@codecov-io
Copy link

codecov-io commented Dec 4, 2018

Codecov Report

Merging #1630 into master will decrease coverage by 0.06%.
The diff coverage is 67.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1630      +/-   ##
===========================================
- Coverage     83.46%   83.4%   -0.07%     
- Complexity     1815    1824       +9     
===========================================
  Files           262     263       +1     
  Lines          8342    8382      +40     
  Branches        803     805       +2     
===========================================
+ Hits           6963    6991      +28     
- Misses         1124    1133       +9     
- Partials        255     258       +3
Impacted Files Coverage Δ Complexity Δ
...ocagent/OcAgentMetricsServiceExportRpcHandler.java 67.5% <67.5%> (ø) 9 <9> (?)
...census/implcore/trace/export/SpanExporterImpl.java 95.89% <0%> (+1.36%) 9% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc04ab9...5e8317c. Read the comment docs.

@songy23 songy23 merged commit 9eb190b into census-instrumentation:master Dec 10, 2018
@songy23 songy23 deleted the oc-agent-metrics-exporter-3 branch December 10, 2018 00:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants