Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Exporter/OcAgent: Add config RPC handler. #1572

Merged

Conversation

songy23
Copy link
Contributor

@songy23 songy23 commented Nov 9, 2018

Split from #1492.

Updates #1408.

@songy23
Copy link
Contributor Author

songy23 commented Nov 9, 2018

Depends on #1569.

@codecov-io
Copy link

codecov-io commented Nov 12, 2018

Codecov Report

Merging #1572 into master will decrease coverage by 1.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1572      +/-   ##
============================================
- Coverage     83.15%   82.11%   -1.05%     
- Complexity     1732     1733       +1     
============================================
  Files           257      259       +2     
  Lines          7966     8067     +101     
  Branches        766      770       +4     
============================================
  Hits           6624     6624              
- Misses         1108     1209     +101     
  Partials        234      234
Impacted Files Coverage Δ Complexity Δ
...e/ocagent/OcAgentTraceServiceConfigRpcHandler.java 0% <0%> (ø) 0 <0> (?)
.../io/opencensus/contrib/http/HttpClientHandler.java 78.26% <0%> (-7.46%) 3% <0%> (ø)
.../io/opencensus/contrib/http/HttpServerHandler.java 88.88% <0%> (-7.12%) 5% <0%> (ø)
...census/implcore/trace/export/SpanExporterImpl.java 91.78% <0%> (-1.37%) 8% <0%> (ø)
...e/ocagent/OcAgentTraceServiceExportRpcHandler.java 0% <0%> (ø) 0% <0%> (?)
...o/opencensus/contrib/http/AbstractHttpHandler.java 87.75% <0%> (+2.04%) 9% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62c0889...ea6b438. Read the comment docs.

@songy23 songy23 merged commit 3047c9f into census-instrumentation:master Nov 13, 2018
@songy23 songy23 deleted the agent-exporter-config-rpc branch November 13, 2018 20:45
@songy23
Copy link
Contributor Author

songy23 commented Nov 13, 2018

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants