-
Notifications
You must be signed in to change notification settings - Fork 202
Testing: Add a fake implementation of TraceService. #1481
Testing: Add a fake implementation of TraceService. #1481
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1481 +/- ##
=========================================
Coverage 82.45% 82.45%
Complexity 1590 1590
=========================================
Files 243 243
Lines 7493 7493
Branches 702 702
=========================================
Hits 6178 6178
Misses 1099 1099
Partials 216 216 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of things:
- I see no intention to publish this to the users.
- Why do we not have the Fake implementation in the test dir?
@bogdandrutu I considered putting this fake server under io.opencensus.testing initially. A few concerns about doing so:
That being said, I agree that there's no need to include the fake server in the ocagent-exporter artifact. I've moved it to |
@songy23 my suggestion was to have it in the src/test/java instead of src/main/java. What do you think? |
427ec98
to
1ddc796
Compare
SGTM, updated. (though it's a bit strange to have tests for a class under test directory.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the fact that tests for test classes is strange; we can move it to the main later but I don't think this should be present in the artifact that gets exported to maven central for example even if this is package protected.
Make sense to me. |
This fake server will be used to test against the clients in #1476.
Equivalent to https://github.com/census-ecosystem/opencensus-go-exporter-ocagent/blob/master/mock_agent_test.go.