This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 202
Implementation of OC-Agent Trace Service clients. #1476
Closed
songy23
wants to merge
9
commits into
census-instrumentation:master
from
songy23:agent-exporter-impl
Closed
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b1a2ed6
Implementation of OC-Agent Trace Service clients.
songy23 f090fec
Update errorprone.
songy23 f341547
Remove duplication.
songy23 eca1915
Allow retry interval to be customized.
songy23 68141ab
Have a daemon thread that runs forever and tries to connect to Agent.
songy23 c2df7c1
Add an option on enabling config to configuration.
songy23 db5397b
Don't block the thread if config is not enabled.
songy23 080143a
Fix review comments.
songy23 96011b2
Remove unnecessary Nullable.
songy23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ | |
package io.opencensus.exporter.trace.ocagent; | ||
|
||
import com.google.auto.value.AutoValue; | ||
import io.opencensus.common.Duration; | ||
import javax.annotation.Nullable; | ||
import javax.annotation.concurrent.Immutable; | ||
|
||
|
@@ -58,6 +59,15 @@ public abstract class OcAgentTraceExporterConfiguration { | |
@Nullable | ||
public abstract String getServiceName(); | ||
|
||
/** | ||
* Returns the retry time interval when trying to connect to Agent. | ||
* | ||
* @return the retry time interval | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "." at the end? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
* @since 0.17 | ||
*/ | ||
@Nullable | ||
public abstract Duration getRetryInterval(); | ||
|
||
/** | ||
* Returns a new {@link Builder}. | ||
* | ||
|
@@ -106,6 +116,15 @@ public abstract static class Builder { | |
*/ | ||
public abstract Builder setServiceName(String serviceName); | ||
|
||
/** | ||
* Sets the retry time interval when trying to connect to Agent. | ||
* | ||
* @param retryInterval the retry time interval. | ||
* @return this. | ||
* @since 0.17 | ||
*/ | ||
public abstract Builder setRetryInterval(Duration retryInterval); | ||
|
||
/** | ||
* Builds a {@link OcAgentTraceExporterConfiguration}. | ||
* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/wort/work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.