Skip to content

Mypyc version is broken #577

Closed
Closed
@andreymal

Description

You made a big mistake uploading the precompiled 3.0.1 version to PyPI — it's installed by default, and it's broken.

With mypyc, the flask_jsonrpc.helpers.get function does not work as intended:

>>> from flask_jsonrpc.helpers import get
>>> get({"id": 1}, path="id")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/project/src/flask_jsonrpc/helpers.py", line 131, in get
TypeError: dict object expected; got int

This is probably because obj_val variable has the dict type. This works fine with regular python, but causes mypyc to disallow storing non-dict values.

There are probably many more broken things that I haven't noticed. I recommend you don't upload mypyc builds to PyPI until they are 100% tested and guaranteed to work.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions