Skip to content

Remove compatibility with Cemuhook and fix exports #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Conversation

Crementif
Copy link
Member

Fixes #31.

Also switches to an in-line way of exporting symbols.

@Crementif Crementif requested a review from Exzap August 26, 2022 16:06
@ArtemisX64
Copy link
Contributor

I was planning on doing something similar. But cool

@Tachi107
Copy link
Contributor

Tachi107 commented Aug 26, 2022

__declspec(dllexport)'s GCC equivalent is __attribute__ ((visibility ("default"))), but I don't know if it is relevant here.

Edit: see https://github.com/Tachi107/cloudflare-ddns/blob/a3a8fd14b367645e81fc9e703150536ca459c681/include/ddns/cloudflare-ddns.h#L45-L72

@ghost
Copy link

ghost commented Aug 26, 2022

Cemuhook is pretty much no longer needed for Cemu, so that's a good sign that Cemuhook is getting abandoned.

@Exzap
Copy link
Member

Exzap commented Aug 26, 2022

Looks good.
End of an era. RIP Cemuhook

@Exzap Exzap merged commit ca78b92 into main Aug 26, 2022
@Crementif
Copy link
Member Author

Crementif commented Aug 26, 2022

__declspec(dllexport)'s GCC equivalent is __attribute__ ((visibility ("default"))), but I don't know if it is relevant here.

Yeah, I'll make a commit changing the DLLEXPORT tomorrow with that, even if there's no need for those kinda functions to be exposed on Linux yet.

@Crementif Crementif mentioned this pull request Aug 28, 2022
Merged
@Crementif Crementif deleted the remove_cemuhook branch August 28, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export support in 2.0
4 participants