Skip to content

udev: replace potential nullptrs by empty strings as we cannot construct std::string with a null const char* #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcelerier merged 1 commit into from
Apr 12, 2025
Merged

udev: replace potential nullptrs by empty strings as we cannot construct std::string with a null const char* #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion include/libremidi/backends/linux/udev.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,15 +165,25 @@ inline udev_soundcard_info get_udev_soundcard_info(const udev_helper& helper, in
entry = udev.list_entry_get_next(entry))
{
auto path = udev.list_entry_get_name(entry);
if (!path)
continue;

auto dev = udev.device_new_from_syspath(helper.instance, path);
auto usb_device = udev.device_get_parent_with_subsystem_devtype(dev, "usb", "usb_device");
if (!dev)
continue;

const auto usb_device
= udev.device_get_parent_with_subsystem_devtype(dev, "usb", "usb_device");

port_information::port_type type = port_information::port_type::hardware;
if (usb_device)
type = (port_information::port_type)(type | port_information::port_type::usb);
else
type = (port_information::port_type)(type | port_information::port_type::pci);

auto id_path = udev.device_get_property_value(dev, "ID_PATH");
if (!id_path)
id_path = "";

auto ret = udev_soundcard_info{.container = id_path, .path = path, .type = type};
udev.device_unref(dev);
Expand Down