Missing link to windowsapp.lib?

[Mengna-Li]

When I tried to install version 5.1.0 in vcpkg, I encountered the following error:

CMakeFiles\libremidi.dir/manifest.res" failed (exit code 1120) with the following output:
   Creating library libremidi.lib and object libremidi.exp
midi_in.cpp.obj : error LNK2019: unresolved external symbol WINRT_IMPL_RoGetActivationFactory referenced in function "struct winrt::hresult __cdecl winrt::impl::get_runtime_activation_factory_impl<0>(struct winrt::param::hstring const &,struct winrt::guid const &,void * *)" (??$get_runtime_activation_factory_impl@$0A@@impl@winrt@@YA?AUhresult@1@AEBUhstring@param@1@AEBUguid@1@PEAPEAX@Z)
midi_out.cpp.obj : error LNK2001: unresolved external symbol WINRT_IMPL_RoGetActivationFactory
observer.cpp.obj : error LNK2001: unresolved external symbol WINRT_IMPL_RoGetActivationFactory
midi_in.cpp.obj : error LNK2019: unresolved external symbol WINRT_IMPL_RoOriginateLanguageException referenced in function "private: void __cdecl winrt::hresult_error::originate(struct winrt::hresult,void *,struct std::source_location const &)" (?originate@hresult_error@winrt@@AEAAXUhresult@2@PEAXAEBUsource_location@std@@@Z)

midi_out.cpp.obj : error LNK2001: unresolved external symbol WINRT_IMPL_RoOriginateLanguageException

observer.cpp.obj : error LNK2001: unresolved external symbol WINRT_IMPL_RoOriginateLanguageException

libremidi.dll : fatal error LNK1120: 2 unresolved externals

ninja: build stopped: subcommand failed.

[jcelerier]

hello! interesting, on windows I never had to link with this library. I'll add it though, it does not hurt.

[Mengna-Li]

I have tried it. Your PR solved my problem, thank you very much.

[dg0yt]

interesting, on windows I never had to link with this library. I'll add it though, it does not hurt.

Maybe it does? No other vcpkg package does that - it is the uwp toolchain which adds it. With that PR, it is pulled into the win32 desktop builds.