Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alfajores release 3 #200

Merged
merged 7 commits into from
Apr 22, 2024
Merged

Alfajores release 3 #200

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1b668e6
alfajores contract release
soloseng Apr 15, 2024
84cd31f
updated deployed contract abis
soloseng Apr 15, 2024
263d3f3
Updated deploy script to use existing libraby
soloseng Apr 16, 2024
766d0cf
- updated DefaultStrategy main ABI
soloseng Apr 16, 2024
da09bf2
tooling to generate MultiSig proposal payload for v3 contract upgrade
soloseng Apr 16, 2024
fc52082
++ multisig edge case test
soloseng Apr 16, 2024
4812b5c
hardcoded multisig signer address
soloseng Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
hardcoded multisig signer address
  • Loading branch information
@soloseng
soloseng committed Apr 22, 2024
commit 4812b5ccc3d8af9021178d475351bd6df46ef7e9
15 changes: 11 additions & 4 deletions lib/multiSig-tasks/update-v2-to-v3.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ import {
ACCOUNT,
ACCOUNT_DESCRIPTION,
MULTISIG_UPDATE_V2_V3_DESCRIPTION,
OWNER_ADDRESS,
OWNER_ADDRESS_DESCRIPTION,
} from "../helpers/staticVariables";
import { taskLogger } from "../logger";
import {
Expand All @@ -23,7 +21,7 @@ import {
const ADDRESS_ZERO = "0x0000000000000000000000000000000000000000";

task(MULTISIG_UPDATE_V2_V3, MULTISIG_UPDATE_V2_V3_DESCRIPTION)
.addParam(OWNER_ADDRESS, OWNER_ADDRESS_DESCRIPTION, undefined, types.string)
// .addParam(OWNER_ADDRESS, OWNER_ADDRESS_DESCRIPTION, undefined, types.string)
.addOptionalParam(ACCOUNT, ACCOUNT_DESCRIPTION, undefined, types.string)
.setAction(async (args: TransactionArguments, hre) => {
try {
Expand Down Expand Up @@ -57,7 +55,13 @@ task(MULTISIG_UPDATE_V2_V3, MULTISIG_UPDATE_V2_V3_DESCRIPTION)
await generateSetPauser(hre, "RebasedStakedCelo", destinations, values, payloads);

await generateSetMinCountOfActiveGroups(hre, destinations, values, payloads);
await generateMultiSigAddOwner(hre, args.ownerAddress!, destinations, values, payloads);
await generateMultiSigAddOwner(
hre,
"0x01AAe13F65fB90B490E6614adE0bffFA57AC5bbc",
destinations,
values,
payloads
);

taskLogger.info("--destinations", destinations.join(","));
taskLogger.info("--values", values.join(","));
Expand Down Expand Up @@ -144,6 +148,9 @@ async function generateMultiSigAddOwner(
values: number[],
payloads: string[]
) {
if (hre.network.name === "alfajores") {
return;
}
if (ownerAddress === ADDRESS_ZERO || !hre.ethers.utils.isAddress(ownerAddress)) {
throw `Invalid Owner address ${ownerAddress}`;
}
Expand Down