This repository was archived by the owner on May 12, 2025. It is now read-only.
Fix edge case goldToken lookup for epoch rewards at synced head#206
Merged
Conversation
palango
approved these changes
Sep 4, 2023
palango
left a comment
Contributor
There was a problem hiding this comment.
Not relying on the next block looks like the cleaner solution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug that occurs when the block/transaction endpoint is hit for the epoch rewards tx in an epoch block that is at the synced tip of Rosetta’s node. What happens:
block/transaction tries to compute epoch rewards for the last tx in the epoch block, which requires some information that is processed by the monitor service (which updates rosetta’s internal DB)
The fix for this in this PR just looks up the contract address from the tx index of the epoch block. Since this is the last tx in the block, there should not be any other txs that change the
goldTokencontract address between this and the start of the next block (old solution).Tested