This repository was archived by the owner on May 12, 2025. It is now read-only.
Fix gas fee calculation to account for gasTipCap#200
Merged
eelanagaraj merged 3 commits intoAug 4, 2023
Merged
Conversation
palango
reviewed
Aug 4, 2023
eelanagaraj
pushed a commit
that referenced
this pull request
Aug 23, 2023
* Fix gas fee calculation to account for gasTipCap * Add comment for header.baseFee usage * Rename totalTip to effectiveTip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current gas calculation logic in Rosetta is incorrect for
DynamicFeeTxandCeloDynamicFeeTxwhenGasTipCap < GasFeeCap - BaseFee. This PR fixes the logic by usingEffectiveGasTipto directly compute the tip paid to the coinbase and sums this with the calculatedBaseFeeto get the correct total tx gas price.Details:
GasPriceis the tx fee limitGasTipCapGasPrice - BaseFeemin(GasTipCap, GasFeeCap - BaseFee)tx.EffectiveGasTipshould compute the tip properly for both legacy & new dynamic types sinceGasTipCap==GasFeeCap==GasPricefor legacy txs (so should be backwards compatible)Testing
DynamicFeeTxon the global testnetWill run full reconciliation tests on this for the global testnet + ideally on baklava (as part of full G-fork release testing).