This repository was archived by the owner on May 12, 2025. It is now read-only.
Remove Tobin Tax handling#199
Merged
Merged
Conversation
6 tasks
eelanagaraj
force-pushed
the
eelanagaraj/tobin-tax-removal
branch
2 times, most recently
from
ef45d71 to
94800a1
Compare
Contributor
|
I think it makes a lot of sense to clean this up. Looks good from a first look, will check again once the other PRs are merged. |
eelanagaraj
force-pushed
the
eelanagaraj/tobin-tax-removal
branch
2 times, most recently
from
d4dce45 to
466a1c2
Compare
eelanagaraj
force-pushed
the
eelanagaraj/tobin-tax-removal
branch
from
466a1c2 to
b8d89e4
Compare
eelanagaraj
force-pushed
the
eelanagaraj/tobin-tax-removal
branch
from
b8d89e4 to
f938403
Compare
added 6 commits
August 23, 2023 14:31
eelanagaraj
force-pushed
the
eelanagaraj/tobin-tax-removal
branch
from
f938403 to
c2c0e92
Compare
palango
approved these changes
Aug 23, 2023
palango
left a comment
palango
left a comment
Contributor
There was a problem hiding this comment.
Nice, so much (complicated) code removed 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The TobinTax was never activated in a way that Rosetta uses/tracks it (even with the "Toborked" accidental HF), so this PR removes all associated code. Note: it is technically optional (treating it as a 0-tax going forwards would result in the same behavior, but Rosetta logic is simpler without it).
Things removed:
analyzer/types.go