Skip to content

Conversation

@ezdac
Copy link
Contributor

@ezdac ezdac commented Aug 13, 2025

Since we now run a lot of workflows in our self-hosted runners, there is a need to expose the runs-on option to the container-cicd workflow. The default is left at "ubuntu-latest" to avoid any compatibility issues, but it could
be overwritten with e.g. '["self-hosted", "org", "8-cpu"]'.

@ezdac ezdac requested a review from jcortejoso August 13, 2025 09:27
@pputman-clabs
Copy link
Contributor

I'm trying to remember why we did this, but I think there was a problem with the caching related to using self hosted runners sometimes and local runners at other times, and they couldn't reference each others cache? I dont remember. I'm approving this for now but just be aware there may be a need to either revert this or make further changes.

@pputman-clabs pputman-clabs self-requested a review August 29, 2025 17:27
@jcortejoso
Copy link
Member

I'm trying to remember why we did this, but I think there was a problem with the caching related to using self hosted runners sometimes and local runners at other times, and they couldn't reference each others cache? I dont remember. I'm approving this for now but just be aware there may be a need to either revert this or make further changes.

I think it should work normally with independence of the node used, but maybe I'm ignoring something.

I'd just merge it.

@pputman-clabs
Copy link
Contributor

pputman-clabs commented Sep 25, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants