This repository was archived by the owner on Feb 27, 2024. It is now read-only.
bugfix: only fetch AddressLesserGreater when validator is eligible#28
Merged
Conversation
palango
reviewed
Mar 2, 2023
palango
approved these changes
Mar 2, 2023
palango
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! Thanks for fixing it so quickly!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Bug is likely caused by an error in
VoteMetadatawhen revoking votes for an ineligible validator, and would be triggered by anything callingRevokeMetadata(which in turn callsVoteMetadata), so any of thepreprocessRevokefuncs (RevokeActiveVotes,RevokePendingVotesinElection.sol;ReleaseGoldRevokePendingVotes,ReleaseGoldRevokeActiveVoteswhich just call theElection.solversion fromReleaseGold.sol).Election.solrevoke functions require passing in the (lesser, greater) addresses (prev/next addresses in the linked list storing the eligible validators,votes.total.eligible, which crucially excludes ineligible validators). In cases like this one, where validators are not eligible but have votes, the revoke functions simply ignore the lesser/greater addresses and don't update the linked list (since ineligible addresses are excluded).Normal cases need to still find the (lesser, greater) addresses in the linked list of eligible validators, but in cases of ineligible validators, we can set (lesser, greater) to 0 (or anything else. -- Tested this against
Election.soldirectly).Locally running Rosetta with this version of kliento looks like it fixes this issue.
Tested
Election.solin the monorepo (adding protocol tests; will put up a PR for this)