-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM testnet tx-nodes & blockscout #687
Conversation
…monorepo into trevor/vm-testnet-secrets
…r/vm-testnet-tx-nodes
…r/vm-testnet-tx-nodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
=======================================
Coverage 66.66% 66.66%
=======================================
Files 237 237
Lines 7065 7065
Branches 404 471 +67
=======================================
Hits 4710 4710
+ Misses 2277 2275 -2
- Partials 78 80 +2
Continue to review full report at Codecov.
|
…r/vm-testnet-tx-nodes
…-monorepo into trevor/vm-testnet-tx-nodes
Description
Very chunky PR, here's a rundown of what's included which will make review easier:
VM_BASED
KUBERNETES_CLUSTER_NAME
ascelo-networks-dev
. This is so ethstats/blockscout that is on the kube cluster celo-networks-dev will be on the same VPC as the VM testnetutils.ts
and intoenv-utils
. This is what's to blame for the vast majority of file changes. Unfortunately this was necessary because otherwise I was running into circular import issues :(default
VPC network with Terraform, I separated out a module for creating/destroying a network. Celotool makes sure this is not done for the default network. Terraform won't allow a network to be destroyed if it's being used by something, but it causes terraform commands to fail, so this was necessary. Seepackages/terraform-modules/testnet-network/README.md
for more deetsSorry for jamming all this into 1 PR!
Tested
celo-networks-dev
kube cluster and the default VPC network)Other changes
I moved a lot of cluster setup logic out of
celotooljs deploy initial testnet
into a separate function so thatdeploy initial ethstats
ordeploy initial blockscout
will perform the cluster setup if it hasn't been done already.I also ran
terraform fmt
to format the terraform codeRelated issues
Backwards compatibility
All existing commands should be backwards compatible