Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set FullHeaderChainAvailable according to sync mode #931

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Set FullHeaderChainAvailable according to sync mode #931

merged 2 commits into from
Mar 20, 2020

Conversation

mrsmkl
Copy link
Contributor

@mrsmkl mrsmkl commented Mar 19, 2020

Description

FullHeaderChainAvailable was false by default, this might have caused some erroneous behavior.

Tested

Only manual testing.

Other changes

Related issues

Backwards compatibility

@mrsmkl mrsmkl requested review from asaj and timmoreton as code owners March 19, 2020 21:46
nategraf
nategraf approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

cmd/utils/flags.go Outdated Show resolved Hide resolved
@mrsmkl
Update cmd/utils/flags.go
f9d8dc3 
Co-Authored-By: Victor "Nate" Graf <victor@celo.org>
@mrsmkl mrsmkl merged commit 711f0a6 into master Mar 20, 2020
@mrsmkl mrsmkl deleted the mrsmkl/full-header-chain branch March 20, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nategraf nategraf nategraf approved these changes

@asaj asaj Awaiting requested review from asaj

@timmoreton timmoreton Awaiting requested review from timmoreton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrsmkl @nategraf