Benchmarking precompiles, setting other parameters #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsmkl
changed the title
nategraf
approved these changes
Mar 17, 2020
Co-Authored-By: Victor "Nate" Graf <victor@celo.org>
Co-Authored-By: Victor "Nate" Graf <victor@celo.org>
|
Thanks for getting this done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hopefully the precompile gas costs are now good enough. Many of them have basically no cost (calling precompiles costs anyway). The cost of verifying aggregated seals should be checked later when we have a new network running.
Tested
Other changes
Related issues
Backwards compatibility