Gas payment change for audit issue M02 #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaj
reviewed
Feb 26, 2020
core/state_transition.go
Outdated
| if err := st.creditFee(*st.msg.GatewayFeeRecipient(), st.msg.GatewayFee(), st.msg.FeeCurrency()); err != nil { | ||
| log.Error("Failed to credit gateway fee", "err", err) | ||
| return err | ||
| if feeCurrency == nil { |
There was a problem hiding this comment.
This section could probably be cleaned up
added 2 commits
February 26, 2020 18:48
asaj
reviewed
Feb 26, 2020
asaj
reviewed
Feb 27, 2020
| "coinbaseFeeRecipient", st.evm.Coinbase, "coinbaseFee", tipTxFee, | ||
| "comunityFundRecipient", *governanceAddress, "communityFundFee", baseTxFee) | ||
| if feeCurrency == nil { | ||
| if gatewayFeeRecipient != &common.ZeroAddress { |
There was a problem hiding this comment.
Should we refund the gateway fee in this case?
There was a problem hiding this comment.
No, since on payFees we don't debit it if st.msg doesn't have GatewayFeeRecipient
asaj
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tx cost payments with non-gold were changed to minimize the number of emitted events and EVM contract calls.
Tested
The CI in monorepo is currently pointing here.
Other changes
Related issues
Backwards compatibility
Not backwards compatible with old contracts.