Get gas price suggestion from the correct block #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasege
reviewed
Jan 21, 2020
…-price-suggestion-638
lucasege
approved these changes
Jan 29, 2020
…-price-suggestion-638
asaj
approved these changes
Jan 30, 2020
mcortesi
pushed a commit
that referenced
this pull request
Jan 31, 2020
# Conflicts: # internal/ethapi/api.go
lucasege
pushed a commit
that referenced
this pull request
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Get the gas price for the block specified in the RPC call so that it doesn't fail transaction pre-check.
Tested
Only manual testing for now. Perhaps an e2e test could be added.
Other changes
Related issues
Backwards compatibility