Governable block gas limit #522
Conversation
…imum-client-version
|
@mrsmkl when this is ready to review would you mind assigning me (or someone else?) |
| @@ -249,7 +249,7 @@ func makeHeader(parent *types.Block, config *istanbul.Config) *types.Header { | |||
| header := &types.Header{ | |||
| ParentHash: parent.Hash(), | |||
| Number: parent.Number().Add(parent.Number(), common.Big1), | |||
| GasLimit: core.CalcGasLimit(parent, parent.GasLimit(), parent.GasLimit()), | |||
| GasLimit: core.CalcGasLimit(parent, nil, parent.GasLimit(), parent.GasLimit()), | |||
There was a problem hiding this comment.
Do we need to store this in the block header at all anymore, since it can be read from the state trie?
There was a problem hiding this comment.
Well there is still the time before the contracts are deployed, how should that be handled?
There was a problem hiding this comment.
Good question. Should we have a fallback value that we define in protocol_params.go?
| @@ -270,7 +270,7 @@ func makeHeader(parent *types.Block, config *istanbul.Config) *types.Header { | |||
| header := &types.Header{ | |||
| ParentHash: parent.Hash(), | |||
| Number: parent.Number().Add(parent.Number(), common.Big1), | |||
| GasLimit: core.CalcGasLimit(parent, parent.GasLimit(), parent.GasLimit()), | |||
| GasLimit: core.CalcGasLimit(parent, nil), | |||
There was a problem hiding this comment.
I think we should remove this field from the block header
There was a problem hiding this comment.
Perhaps this should be in another PR, changing the header seems to break many things in the tests.
|
It looks like there's an end-to-end test failure |
| @@ -270,7 +270,7 @@ func makeHeader(parent *types.Block, config *istanbul.Config) *types.Header { | |||
| header := &types.Header{ | |||
| ParentHash: parent.Hash(), | |||
| Number: parent.Number().Add(parent.Number(), common.Big1), | |||
| GasLimit: core.CalcGasLimit(parent, parent.GasLimit(), parent.GasLimit()), | |||
| GasLimit: core.CalcGasLimit(parent, nil), | |||
Description
Reads the block gas limit from a governable contract.
Tested
I'll add test to the corresponding PR celo-org/celo-monorepo#1253
Other changes
Related issues
Backwards compatibility