Checking minimum client version #481
Conversation
| const defaultGasAmount = 2000000 | ||
|
|
||
| var ( | ||
| blockchainParametersABI, _ = abi.JSON(strings.NewReader(blockchainParametersABIString)) |
|
About killing the node, perhaps we should check for a confirmed block? |
What do you mean by checking for a confirmed block? Do you mean waiting for an additional block? |
|
Yeah, I was thinking that it would read the value from some parent block. |
| } | ||
|
|
||
| if params.CurrentVersionInfo.Cmp(version) == -1 { | ||
| time.Sleep(10 * time.Second) |
There was a problem hiding this comment.
When testing, it's useful to know that the node cannot exit immediately when making the transaction.
params/protocol_params.go
Outdated
| @@ -156,3 +157,5 @@ const ( | |||
| // We charge for reading the balance, 1 debit, and 3 credits (refunding gas, paying the gas fee recipient, sending to the infrastructure fund) | |||
| AdditionalGasForNonGoldCurrencies uint64 = 3*ExpectedGasForCreditToTransactions + ExpectedGasForDebitFromTransactions + ExpectedGasToReadErc20Balance | |||
| ) | |||
|
|
|||
| const ContractCommGas uint64 = 2000000 // gas amount used for querying system contracts | |||
There was a problem hiding this comment.
I don't think this is entirely accurate, as if you look above we specify different amounts for different calls to system contracts. Instead, consider specifying one specific to this call, e.g. MaxGasForGetMinimumClientVersion
| @@ -97,7 +97,7 @@ const ( | |||
| ]` | |||
| ) | |||
|
|
|||
| const defaultGasAmount = 2000000 | |||
| const defaultGasAmount = params.ContractCommGas | |||
contract_comm/random/random.go
Outdated
| @@ -84,7 +84,7 @@ const ( | |||
| "type": "function" | |||
| } | |||
| ]` | |||
| gasAmount = 1000000 | |||
| gasAmount = params.ContractCommGas | |||
| var err error | ||
| blockchainParametersABI, err = abi.JSON(strings.NewReader(blockchainParametersABIString)) | ||
| if err != nil { | ||
| log.Error("Error reading ABI for BlockchainParameters", "err", err) |
There was a problem hiding this comment.
probably fatal here, since this happens on startup and the erros means a developer bug
Description
Checks the minimum client version from a smart contract, exits with error message if required version is larger than current version.
Tested
Still need to figure out how to test.
Other changes
Related issues
PR for the smart contract: celo-org/celo-monorepo#1081
Backwards compatibility