Skip to content

Commit

Permalink
fix: Fixed race condition in action server between is_ready and take" (
Browse files Browse the repository at this point in the history
…ros2#2495)

Some background information: is_ready, take_data and execute data
may be called from different threads in any order. The code in the old
state expected them to be called in series, without interruption.
This lead to multiple race conditions, as the state of the pimpl objects
was altered by the three functions in a non thread safe way.

Co-authored-by: William Woodall <william@osrfoundation.org>
Signed-off-by: Janosch Machowinski <J.Machowinski@cellumation.com>
  • Loading branch information
2 people authored and Janosch Machowinski committed Jun 25, 2024
1 parent c1a01fc commit cfd020c
Show file tree
Hide file tree
Showing 2 changed files with 435 additions and 241 deletions.
Loading

0 comments on commit cfd020c

Please sign in to comment.