This ports Celluloid::ZMQ to CZTop. #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chuckremes it would appear this is is most appropriately yours to pull the trigger on! |
|
That's a huge honor. I'll poke at this tomorrow/Monday. So far I see there are conflicts, so maybe @paddor can resolve the conflicts on the branch to make things go a bit smoother. |
|
Thanks, and of of course I'll do anything to make this smoother. But I'm sorry, I can't see the conflicts. Apart from the message here on Github that there are conflicts, I can't see any, neither on Github, nor when I |
|
Finally found the culprit. My git remotes were wrong. Fixing the conflicts... |
|
Filing another PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code changes are pretty simple. The test suite passes. It also updates the README and culture (celluloid/culture#36 should be merged first).