Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting and getting socket options #27

Merged
merged 1 commit into from
Feb 4, 2014
Merged

Allow setting and getting socket options #27

merged 1 commit into from
Feb 4, 2014

Conversation

jasonroelofs
Copy link
Contributor

With the release of ZeroMQ 4, there are ever more options that can be set on a socket. Specifically in my case, the security options. This PR adds #set and #get to sockets which just proxy the arguments directly down to the ffi-rzmq handler for the socket. Celluloid doesn't have to care about types, that's handled deeper down.

@jasonroelofs
Copy link
Contributor Author

The build is failing because of changes made in Celluloid 0.16 (not out yet) and this project pulls in Celluloid from master via bundler. Tests pass fine on Celluloid 0.15.

@tarcieri
Copy link
Member

Seems good. By "security options" do you mean CurveZMQ? That is definitely something I'm interested, and while I've been tracking the protocol changes vs CurveCP, I haven't done much digging into the actual implementation.

I would like to get the tests passing with Celluloid 0.16 first, then maybe we can rebase this and merge when the tests pass again?

@jasonroelofs
Copy link
Contributor Author

Yep! Curve is delightfully easy to set up and use. I put together a quick example here: https://github.com/chuckremes/ffi-rzmq/blob/master/examples/repreq_over_curve.rb. And sure, I'll keep an eye on things and keep this branch up-to-date.

@tarcieri
Copy link
Member

Wanted to give this more scrutiny because it's security-related, but this change looks rather trivial. Also the build failures seem to be unrelated.

tarcieri added a commit that referenced this pull request Feb 4, 2014
Allow setting and getting socket options
@tarcieri tarcieri merged commit 4a84b34 into celluloid:master Feb 4, 2014
@tarcieri
Copy link
Member

tarcieri commented Feb 4, 2014

Seems good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants