Code generation: still need to convert some "algebraic" stuff to "algebraic variable"#1359
Open
agarny wants to merge 1 commit intocellml:mainfrom
Open
Code generation: still need to convert some "algebraic" stuff to "algebraic variable"#1359agarny wants to merge 1 commit intocellml:mainfrom
agarny wants to merge 1 commit intocellml:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes issue #1353 by standardizing variable naming in generated code from CamelCase to snake_case. The changes convert references to algebraicVariables, algebraic, externalVariables to their snake_case equivalents: algebraic_variables, external_variables.
Changes:
- Updated Python function signatures to use
algebraic_variablesparameter instead ofalgebraic - Renamed all variable references from
algebraicVariablestoalgebraic_variablesin Python files - Renamed all variable references from
externalVariablestoexternal_variablesin Python files - Updated C/C++ header function signatures to use
algebraicVariablesinstead ofalgebraic - Bumped version numbers from "0.6.0"/"0.7.0" to "0.8.0" across test resource files
Reviewed changes
Copilot reviewed 232 out of 243 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/resources/generator/variable_initialised_using_another_variable/model.py | Updated variable naming from CamelCase to snake_case and version bump |
| tests/resources/generator/variable_initialised_using_another_variable/model.h | Updated function signature parameter name |
| tests/resources/generator/variable_initialised_using_another_variable/model.c | Updated function signature and version |
| tests/resources/generator/unknown_variable_as_external_variable/model.* | Standardized naming conventions for algebraic and external variables |
| tests/resources/generator/sine_model_imports/model.* | Updated variable references and function signatures |
| tests/resources/generator/robertson_model_1966/model.. | Applied consistent naming throughout ODE and DAE variants |
| tests/resources/generator/ode_/model. | Standardized variable naming across multiple ODE test cases |
| tests/resources/generator/noble_model_1962/model.* | Updated all variable references to snake_case |
| tests/resources/generator/hodgkin_huxley_squid_axon_model_1952/model.. | Comprehensive updates across all model variants (ODE, DAE, external, tracking, etc.) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…les` rather than `algebraic`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1353.