Passing figsize argument to plt.savefig() is deprecated for matplotlib>3.6

[ufuk-cakir]

Running the current version of Cell2Fire(0.2) with Python (3.11.10) and matplotlib=3.10.1 on MacOS 15.4 results in an error.

Description

Calling GlobalFireSpreadEvo() results in a TypeError:

TypeError: FigureCanvasAgg.print_png() got an unexpected keyword argument ‘figsize’

Cause

This happens because figsize is passed to plt.savefig(), but it is not a valid keyword argument there. figsize should be passed when creating the figure using plt.figure(figsize=(...)).

This was deprecated for matplotlib>3.6, see here.

Here are some examples where this happens:

Cell2Fire/attic/Plot.py

Line 303 in 544c83c

plt.savefig(PathFile, dpi=200, figsize=(200, 200), bbox_inches='tight', transparent=True)

Fix

• either fix matplotlib in requirements file to matplotlib<3.6
• or (recommended)

# Replace these:
plt.savefig("output.png", figsize=(10, 6), dpi=300)

# With:
plt.figure(figsize=(10, 6))
...
plt.savefig("output.png", dpi=300)

[DLWoodruff]

I agree with your recommended fix and I will try to get to it soon. Of course, I would approve your PR to make the change more quickly!

…

On Fri, Apr 18, 2025 at 4:34 AM Ufuk Çakır ***@***.***> wrote: Running the current version of Cell2Fire(0.2) with Python (3.11.10) and matplotlib=3.10.1 on MacOS 15.4 results in an error. *Description* Calling GlobalFireSpreadEvo() results in a TypeError: TypeError: FigureCanvasAgg.print_png() got an unexpected keyword argument ‘figsize’ *Cause* This happens because figsize is passed to plt.savefig(), but it is not a valid keyword argument there. figsize should be passed when creating the figure using plt.figure(figsize=(...)). This was deprecated for matplotlib>3.6, see here <https://stackoverflow.com/questions/79208260/matplotlib-savefig-figsize-which-is-no-longer-supported-as-of-3-3-and-will> . Here are some examples where this happens: https://github.com/cell2fire/Cell2Fire/blob/544c83c535d9d5a0243e9ac18c9461eb42b7a77e/attic/Plot.py#L303 *Fix* - either fix matplotlib in requirements file to matplotlib<3.6 - or (recommended) # Replace these:plt.savefig("output.png", figsize=(10, 6), dpi=300) # With:plt.figure(figsize=(10, 6)) ...plt.savefig("output.png", dpi=300) — Reply to this email directly, view it on GitHub <#128>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4VTBFHIE4ABUDZMGE6AG322DPKRAVCNFSM6AAAAAB3M4NNR6VHI2DSMVQWIX3LMV43ASLTON2WKOZTGAYDINZWGM4DGMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> *ufuk-cakir* created an issue (cell2fire/Cell2Fire#128) <#128> Running the current version of Cell2Fire(0.2) with Python (3.11.10) and matplotlib=3.10.1 on MacOS 15.4 results in an error. *Description* Calling GlobalFireSpreadEvo() results in a TypeError: TypeError: FigureCanvasAgg.print_png() got an unexpected keyword argument ‘figsize’ *Cause* This happens because figsize is passed to plt.savefig(), but it is not a valid keyword argument there. figsize should be passed when creating the figure using plt.figure(figsize=(...)). This was deprecated for matplotlib>3.6, see here <https://stackoverflow.com/questions/79208260/matplotlib-savefig-figsize-which-is-no-longer-supported-as-of-3-3-and-will> . Here are some examples where this happens: https://github.com/cell2fire/Cell2Fire/blob/544c83c535d9d5a0243e9ac18c9461eb42b7a77e/attic/Plot.py#L303 *Fix* - either fix matplotlib in requirements file to matplotlib<3.6 - or (recommended) # Replace these:plt.savefig("output.png", figsize=(10, 6), dpi=300) # With:plt.figure(figsize=(10, 6)) ...plt.savefig("output.png", dpi=300) — Reply to this email directly, view it on GitHub <#128>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4VTBFHIE4ABUDZMGE6AG322DPKRAVCNFSM6AAAAAB3M4NNR6VHI2DSMVQWIX3LMV43ASLTON2WKOZTGAYDINZWGM4DGMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[DLWoodruff]

Dear Ufuk, PR#129 is intended to fix the two issues you raised. Could you please give it a try before I merge it? Thanks, Dave

…

On Fri, Apr 18, 2025 at 4:34 AM Ufuk Çakır ***@***.***> wrote: Running the current version of Cell2Fire(0.2) with Python (3.11.10) and matplotlib=3.10.1 on MacOS 15.4 results in an error. *Description* Calling GlobalFireSpreadEvo() results in a TypeError: TypeError: FigureCanvasAgg.print_png() got an unexpected keyword argument ‘figsize’ *Cause* This happens because figsize is passed to plt.savefig(), but it is not a valid keyword argument there. figsize should be passed when creating the figure using plt.figure(figsize=(...)). This was deprecated for matplotlib>3.6, see here <https://stackoverflow.com/questions/79208260/matplotlib-savefig-figsize-which-is-no-longer-supported-as-of-3-3-and-will> . Here are some examples where this happens: https://github.com/cell2fire/Cell2Fire/blob/544c83c535d9d5a0243e9ac18c9461eb42b7a77e/attic/Plot.py#L303 *Fix* - either fix matplotlib in requirements file to matplotlib<3.6 - or (recommended) # Replace these:plt.savefig("output.png", figsize=(10, 6), dpi=300) # With:plt.figure(figsize=(10, 6)) ...plt.savefig("output.png", dpi=300) — Reply to this email directly, view it on GitHub <#128>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4VTBFHIE4ABUDZMGE6AG322DPKRAVCNFSM6AAAAAB3M4NNR6VHI2DSMVQWIX3LMV43ASLTON2WKOZTGAYDINZWGM4DGMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> *ufuk-cakir* created an issue (cell2fire/Cell2Fire#128) <#128> Running the current version of Cell2Fire(0.2) with Python (3.11.10) and matplotlib=3.10.1 on MacOS 15.4 results in an error. *Description* Calling GlobalFireSpreadEvo() results in a TypeError: TypeError: FigureCanvasAgg.print_png() got an unexpected keyword argument ‘figsize’ *Cause* This happens because figsize is passed to plt.savefig(), but it is not a valid keyword argument there. figsize should be passed when creating the figure using plt.figure(figsize=(...)). This was deprecated for matplotlib>3.6, see here <https://stackoverflow.com/questions/79208260/matplotlib-savefig-figsize-which-is-no-longer-supported-as-of-3-3-and-will> . Here are some examples where this happens: https://github.com/cell2fire/Cell2Fire/blob/544c83c535d9d5a0243e9ac18c9461eb42b7a77e/attic/Plot.py#L303 *Fix* - either fix matplotlib in requirements file to matplotlib<3.6 - or (recommended) # Replace these:plt.savefig("output.png", figsize=(10, 6), dpi=300) # With:plt.figure(figsize=(10, 6)) ...plt.savefig("output.png", dpi=300) — Reply to this email directly, view it on GitHub <#128>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4VTBFHIE4ABUDZMGE6AG322DPKRAVCNFSM6AAAAAB3M4NNR6VHI2DSMVQWIX3LMV43ASLTON2WKOZTGAYDINZWGM4DGMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>